Type abscissaScale and ordinateScale more strictly
#1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1431 to enforce stricter types for the internal
createScaleandgetCanvasScaleutility functions, and therefore forabscissaScaleandordinateScale(exposed throughVisCanvasContext).To do so, I've added a generic to
Scale, in order forabscissaScaleandordinateScaleto be typed asScale<AxisScaleType>, and I've reintroducedAxisScale(removed in #1431, as before it incorrectly meant "any of the supported scales") as an alias to this type.The Storybook was still saying that the type of
abscissaScaleandordinateScalewasAxisScaleeven though it had basically been renamed toScalein #1431. But with the stronger typing and the reintroduction ofAxisScale, it is now correct.