Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add error handling to BaseAudioContext::new_inherited #33023

Merged
merged 6 commits into from
Aug 18, 2024
Merged

fix: add error handling to BaseAudioContext::new_inherited #33023

merged 6 commits into from
Aug 18, 2024

Conversation

Taym95
Copy link
Contributor
@Taym95 Taym95 commented Aug 12, 2024 •
edited
Loading
  • There are tests for these changes OR
  • These changes do not require tests because ___

@Taym95 Taym95 requested a review from gterzian as a code owner August 12, 2024 17:15
@Taym95 Taym95 marked this pull request as draft August 12, 2024 17:15
@sagudev sagudev changed the title fix: add error handling to BaseAudioContex::tnew_inherited fix: add error handling to BaseAudioContext::new_inherited Aug 13, 2024
@Taym95 Taym95 force-pushed the feature/error-handling-base-audio-context-init branch from dd48881 to fdcdd2f Compare August 13, 2024 10:04
@Taym95 Taym95 marked this pull request as ready for review August 13, 2024 10:06
@Taym95 Taym95 force-pushed the feature/error-handling-base-audio-context-init branch from fdcdd2f to adc4d57 Compare August 13, 2024 11:23
jdm
jdm approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member
@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jdm jdm added the T-linux-wpt-2020 Do a try run of the WPT label Aug 13, 2024
@github-actions github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Aug 13, 2024
@github-actions GitHub Actions
Copy link

🔨 Triggering try run (#10369821790) for Linux WPT

@github-actions GitHub Actions
Copy link

Test results for linux-wpt-layout-2020 from try job (#10369821790):

Flaky unexpected result (20)
  • OK /_mozilla/css/stylesheet_media_queries.html (#17159)
    • FAIL [expected PASS] subtest: Media queries within stylesheets

      assert_equals: expected "rgb(255, 0, 0)" but got "rgb(0, 255, 0)"

  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
    • NOTRUN [expected PASS] subtest: Overall test
  • OK /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
    • FAIL [expected PASS] subtest: looks up handleEvent method on every event dispatch

      assert_equals: expected 2 but got 1

  • OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
    • FAIL [expected PASS] subtest: listeners are called correct number of times

      assert_equals: expected 2 but got 1

  • TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
    • TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up

      Test timed out

  • OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
    • PASS [expected FAIL] subtest: Check execution order on load handler
    • PASS [expected FAIL] subtest: Check execution order from nested timeout
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
    • PASS [expected FAIL] subtest: Navigating to a different document with link click
    • PASS [expected FAIL] subtest: Navigating to a different document with form submission
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
    • FAIL [expected PASS] subtest: Same-origin navigation started from unload handler must be ignored

      assert_equals: expected "?pass" but got "?fail"

  • TIMEOUT [expected OK] /html/browsers/history/the-location-interface/assign-replace-from-iframe.html (#31638)
    • TIMEOUT [expected PASS] subtest: Browser sends Referer header in iframe request when location.replace is called from an iframe

      Test timed out

    • TIMEOUT [expected PASS] subtest: Browser sends Referer header in iframe request when location.assign is called from an iframe

      Test timed out

  • CRASH [expected OK] /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
  • ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html (#32745)
  • ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-invalid-args.html (#32745)
  • OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
  • OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
    • FAIL [expected PASS] subtest: DOMParser

      assert_unreached: got unexpected load event Reached unreachable code

    • FAIL [expected PASS] subtest: createHTMLDocument

      assert_unreached: got unexpected error event Reached unreachable code

    • FAIL [expected PASS] subtest: <template>

      assert_unreached: got unexpected error event Reached unreachable code

  • OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
    • PASS [expected FAIL] subtest: text/plain: backslash in name (formdata event)
  • OK /html/semantics/forms/historical.html (#28568)
    • PASS [expected FAIL] subtest: <input name=isindex> should not be supported
  • OK /resource-timing/status-codes-create-entry.html (#28675)
    • PASS [expected FAIL] subtest: Make sure all status codes are reported
  • OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
    • PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
  • OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)
Stable unexpected results that are known to be intermittent (11)
  • FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
  • FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
  • FAIL [expected PASS] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
  • FAIL [expected PASS] /css/css-values/vh_not_refreshing_on_chrome.html (#23385, #15570)
  • OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
    • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted

      assert_array_equals: Pages opened during history navigation lengths differ, expected array [6, 3] length 2, got [6, 2, 2] length 3

  • TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
  • OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
  • ERROR /resource-timing/content-type-parsing.html (#29131)
    • TIMEOUT [expected FAIL] subtest: mime-type 16 : text/html;charset=�gbk

      Test timed out

    • NOTRUN [expected TIMEOUT] subtest: mime-type 17 : text/html;charset= gbk
  • TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
    • FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)

      assert_equals: expected 7110144 but got 7110400

  • OK [expected CRASH] /url/failure.html (#28574)
Stable unexpected results (1)
  • TIMEOUT [expected OK] /fetch/metadata/audio-worklet.https.html

@github-actions GitHub Actions
Copy link

⚠️ Try run (#10369821790) failed.

@Taym95
Copy link
Contributor Author
Taym95 commented Aug 13, 2024

Test results for linux-wpt-layout-2020 from try job (#10369821790):

Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (11)
Stable unexpected results (1)

  • TIMEOUT [expected OK] /fetch/metadata/audio-worklet.https.html

Interesting, how can test timeout and I am returning error now?!

@jdm
Copy link
Member
jdm commented Aug 13, 2024

Have you tested the original test from #32986 locally? I'd like to know why it's still crashing.

@Taym95
Copy link
Contributor Author
Taym95 commented Aug 13, 2024

Have you tested the original test from #32986 locally? I'd like to know why it's still crashing.

Yes it is not crashing but timeout:

0:02.80 TEST_START: /webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html
 0:02.80 WARNING Got command init_succeeded in state running
 0:27.80 INFO Got timeout in harness
 0:27.80 TEST_END: TIMEOUT, expected CRASH - TestRunner hit external timeout (this may indicate a hang)
 0:27.80 INFO Pausing until the browser exits

@Taym95
Copy link
Contributor Author
Taym95 commented Aug 13, 2024 •
edited
Loading

Great news, it's passing now! The issue was in other PR—receiver was blocking:

image

@Taym95 Taym95 force-pushed the feature/error-handling-base-audio-context-init branch 2 times, most recently from c5d12d0 to dc03076 Compare August 14, 2024 12:51
@gterzian gterzian added the T-linux-wpt-2020 Do a try run of the WPT label Aug 15, 2024
@github-actions github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Aug 15, 2024
@github-actions GitHub Actions
Copy link

🔨 Triggering try run (#10402430018) for Linux WPT

@github-actions GitHub Actions
Copy link

⚠️ Try run (#10402430018) failed.

@gterzian
Copy link
Member

https://github.com/servo/servo/actions/runs/10402430018/job/28806906443#step:11:35

@Taym95 Taym95 force-pushed the feature/error-handling-base-audio-context-init branch from dc03076 to 931ffb8 Compare August 16, 2024 09:54
@Taym95 Taym95 mentioned this pull request Aug 17, 2024
Closed
7 tasks
@Taym95
Update servo-media
083894d 
Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>
@Taym95 Taym95 force-pushed the feature/error-handling-base-audio-context-init branch from 931ffb8 to 083894d Compare August 17, 2024 15:12
@Taym95
Update test expectations
e2542e1 
Signed-off-by: Taym <haddadi.taym@gmail.com>
@jdm jdm enabled auto-merge August 18, 2024 13:40
@jdm jdm added this pull request to the merge queue Aug 18, 2024
Merged via the queue into servo:main with commit a24e927 Aug 18, 2024
10 of 11 checks passed
@Taym95 Taym95 mentioned this pull request Sep 2, 2024
Closed
@jdm jdm mentioned this pull request Sep 2, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html
3 participants
@Taym95 @jdm @gterzian