-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Rust 1.78 #32217
Update to Rust 1.78 #32217
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
@mrobinson land it, if it is OK. |
This could be due to LLVM bump in rust. |
I believe its the debug assertions being enabled in the standard library now in Rust 1.78. |
|
Right, that makes much more sense. |
Apparently destination pointer is null although it shouldn't be as this was checked upon it's creation: https://github.com/sagudev/ipc-channel/blob/4c01b78a108d761ac67407da1359b8293c7c93ef/src/platform/unix/mod.rs#L803 |
|
Related: servo/ipc-channel#268 |
🔨 Triggering try run (#8951653290) for Linux WPT, MacOS, Windows, Android |
Testing servo/ipc-channel#335 |
🔨 Triggering try run (#8951738888) for Linux WPT, MacOS, Windows, Android |
Test results for linux-wpt-layout-2013 from try job (#8951738888): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (8)
Stable unexpected results (25)
|
Test results for linux-wpt-layout-2020 from try job (#8951738888): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (12)
Stable unexpected results (17)
|
|
I guess there are even more debug assert failures, this time unrelated to ipc-channel. (I somehow knew, that it was to good to be true for whole repo to be good; although why they were not triggered before? rebase?). EDIT: I think rebase helps as I cannot reproduce it on my machine. |
Rebased. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
🔨 Triggering try run (#9327631562) for Linux WPT, MacOS, Windows, Android |
Test results for linux-wpt-layout-2013 from try job (#9327631562): Flaky unexpected result (8)
Stable unexpected results that are known to be intermittent (7)
|
Test results for linux-wpt-layout-2020 from try job (#9327631562): Flaky unexpected result (10)
Stable unexpected results that are known to be intermittent (9)
|
✨ Try run (#9327631562) succeeded. |
* Update to rust 1.78 * Update crown for rust 1.78 * rust 1.78 is now stable * Update for nix * Update comment Co-authored-by: Martin Robinson <mrobinson@igalia.com> * Update support/crown/src/common.rs * Update support/crown/Cargo.toml * Update support/crown/src/common.rs * Fix ipc problem * Update ipc-channel to 0.18.1 * fixed fixme --------- Co-authored-by: Martin Robinson <mrobinson@igalia.com>
Somebody asked for it.
Everybody will need to rerun
mach bootstrap
to rebuild crown (can we do this automatically?).Requires new version of ipc-channel.
Fixes #32413
./mach build -d
does not report any errors./mach test-tidy
does not report any errors