Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tutorials on Windows #708

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix tutorials on Windows #708

wants to merge 3 commits into from

Conversation

itrushkin
Copy link
Contributor

@itrushkin itrushkin mentioned this pull request Jan 24, 2023
Open
@itrushkin
Remove remaining num_workers usages
5b925ed 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin itrushkin marked this pull request as ready for review February 6, 2023 16:44
@itrushkin
Copy link
Contributor Author

The merge of this PR may also fix the MemoryError on Windows.

igor-davidyuk
igor-davidyuk approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor
@igor-davidyuk igor-davidyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

mansishr
mansishr requested changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator
@mansishr mansishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could we add this to the documentation that num_workers>0 can be used on ubuntu so that users have that option?

@itrushkin
Copy link
Contributor Author

LGTM, but could we add this to the documentation that num_workers>0 can be used on ubuntu so that users have that option?

@mansishr I like the idea of documenting the ability to speed up the data loading but the num_workers issue is not related to OpenFL. It appears even in non-federated usage of DataLoader. Users always have the option of setting the num_workers because torch.utils.data.DataLoader class accepts it. Why do we need to tell users how to use PyTorch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansishr mansishr mansishr requested changes

@aleksandr-mokrov aleksandr-mokrov aleksandr-mokrov approved these changes

@igor-davidyuk igor-davidyuk igor-davidyuk approved these changes

@psfoley psfoley Awaiting requested review from psfoley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows support in OpenFL tutorials
4 participants
@itrushkin @aleksandr-mokrov @igor-davidyuk @mansishr