Fix "Response length returned exceeded limit" error #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ensure we read the full response
asgrim
commented
Nov 1, 2022
| /** @param resource $socketResource */ | ||
| public static function readingResponseContentFromSocket(Command $attemptedCommand, $socketResource, ConnectionAddress $connectionAddress): self | ||
| { | ||
| public static function readingResponseContentFromSocket( |
There was a problem hiding this comment.
This is indeed a minor BC break:
# Changed
- [BC] The number of required arguments for Scoutapm\Connector\Exception\FailedToSendCommand::readingResponseContentFromSocket() increased from 3 to 6
- [BC] The parameter $socketResource of Scoutapm\Connector\Exception\FailedToSendCommand::readingResponseContentFromSocket() changed from no type to a non-contravariant int
- [BC] The parameter $connectionAddress of Scoutapm\Connector\Exception\FailedToSendCommand::readingResponseContentFromSocket() changed from Scoutapm\Connector\ConnectionAddress to a non-contravariant int
Although it is highly unlikely to affect downstream consumers of the library, since this named constructor for the exception is likely only useful internally (although "catching" the exception is not BC broken as such, although the message has changed slightly. Just something to be aware of, but the impact on consumers is expected to be very minimal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #289