-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make styleguidist server publicly accessible #671
Conversation
Add doc: "How to make styleguidist server publicly accessible?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request!
Please also add a warning that this setup is not recommended for security reasons.
docs/Cookbook.md
Outdated
@@ -254,6 +255,21 @@ module.exports = { | |||
|
|||
![](https://d3vv6lp55qjaqc.cloudfront.net/items/3i3E3j2h3t1315141k0o/debugging.png) | |||
|
|||
## How to make styleguidist server publicly accessible? | |||
|
|||
In order to make styleguidist server publicly accessible, add the following to the styleguide.config.js file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- styleguidist → Styleguidist
Codecov Report
|
docs/Cookbook.md
Outdated
@@ -257,6 +257,8 @@ module.exports = { | |||
|
|||
## How to make styleguidist server publicly accessible? | |||
|
|||
Warning: this setup is not recommended for security reasons, it should only be enabled on dev environments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think the second part is necessary, I think it’s dangerous in any case ;-)
Also: **Warning:**
docs/Cookbook.md
Outdated
@@ -257,6 +257,8 @@ module.exports = { | |||
|
|||
## How to make styleguidist server publicly accessible? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
styleguidist → Styleguidist
It would be a good addition to add a link to the original issue webpack/webpack-dev-server#887 to illustrate what exactly the security risk here is about. |
😴 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week without any further activity. Thank you for your contributions. |
Add doc: "How to make styleguidist server publicly accessible?"