Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make styleguidist server publicly accessible #671

Closed
wants to merge 2 commits into from
Closed

Make styleguidist server publicly accessible #671

wants to merge 2 commits into from

Conversation

ghost
Copy link
@ghost ghost commented Nov 6, 2017

Add doc: "How to make styleguidist server publicly accessible?"

Add doc: "How to make styleguidist server publicly accessible?"
Copy link
Member
@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

Please also add a warning that this setup is not recommended for security reasons.

docs/Cookbook.md Outdated
@@ -254,6 +255,21 @@ module.exports = {

![](https://d3vv6lp55qjaqc.cloudfront.net/items/3i3E3j2h3t1315141k0o/debugging.png)

## How to make styleguidist server publicly accessible?

In order to make styleguidist server publicly accessible, add the following to the styleguide.config.js file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • styleguidist → Styleguidist

@codecov-io
Copy link

Codecov Report

Merging #671 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted Files Coverage Δ
loaders/props-loader.js 91.42% <0%> (ø) ⬆️
loaders/utils/parseExample.js 100% <0%> (ø) ⬆️
loaders/utils/getProps.js 100% <0%> (ø) ⬆️
loaders/utils/getNameFromFilePath.js 100% <0%> (ø)

docs/Cookbook.md Outdated
@@ -257,6 +257,8 @@ module.exports = {

## How to make styleguidist server publicly accessible?

Warning: this setup is not recommended for security reasons, it should only be enabled on dev environments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think the second part is necessary, I think it’s dangerous in any case ;-)

Also: **Warning:**

docs/Cookbook.md Outdated
@@ -257,6 +257,8 @@ module.exports = {

## How to make styleguidist server publicly accessible?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styleguidist → Styleguidist

@n1313
Copy link
Collaborator
n1313 commented Jan 10, 2018

It would be a good addition to add a link to the original issue webpack/webpack-dev-server#887 to illustrate what exactly the security risk here is about.

@stale
Copy link
stale bot commented Dec 28, 2018

😴 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week without any further activity. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 28, 2018
@stale stale bot closed this Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants