delete state of metrics on ring members change #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending this PR In order to deal the following #716.
There is a different PR #348 which is not working. After I've looked into that code I've noticed that it try to resert state by using
delfunctions without any argument.According to documentation,
delfunctions can delete one metric or folders of metrics, I've added a new delete ability which delete all metrics with*sign.In addition, I've toggle this feature using proxy configuration file in order to not force this behavior for the user.
This feature should be a replacement to the existing
deleteIdleStats: true.