Use parallel tests + avoid partial matching #1384
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for pointing out those partial matches, I have fixed them in ab30e7b. I am less sure about parallel tests because |
|
Great! I will close in this case. I read that it should be handled already r-lib/testthat#1114 (comment), but can't confirm it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prework
Summary
Speed up test by using testthat parallel (on CI -2 minutes for testing on ubuntu (10min44 to 9min29) + avoid partial matching (caught by having this set in Rprofile)
options( warnPartialMatchArgs = TRUE, warnPartialMatchDollar = TRUE, warnPartialMatchAttr = TRUE )This contribution is meaningless, but thought I'd send it anyway! By looking at the most time consuming tests, I set them to run first with testthat which reduces test run time !
I am actually trying to find a way to make messages more colorful but didn't succeed (yet)
My goal is to end up with a message that looks like this
Currently, it looks like this