Change all octothorpes # to _ since private # is only >=ES2022 #1319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Users upgrading to v3.0.0-beta.2 encountered build failures with the following error:
This occurred when bundlers (like Next.js, Vite, or custom Webpack configs) attempted to process our source files that contained ES2022 private class fields and methods (
#privateField
).Since our SDK transpiles ES2021 into ES5 for broad compatibility, we cannot use syntax that requires additional Babel plugins that users may not have configured.
This PR replaces all private class syntax (
#
) with the underscore convention (_
) to maintain backward compatibility while preserving the intended encapsulation pattern.Type of change
Related issues