chore: Make promise a dependency instead of peer dependency #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the completed pull request description for your changes.
Description of the change
This pull request resolves an issue where
promise
was listed as apeerDependency
, causing a warning to appear when usingrollbar-react-native
in other projects. By movingpromise
todependencies
, this change resolves the warning and ensuresrollbar-react-native
works as expected out of the box.The motivation for this change is that while
promise
is typically provided by React Native, its inclusion as apeerDependency
created an unnecessary dependency management burden for consumers of this library. The issue is detailed in this GitHub issue:https://github.com/rollbar/rollbar-react-native/issues/211
.Type of change
Related issues
Checklists
Development
Code review