Description of the change

This resolves an issue with the current creation of a TelemetryBody instance in TelemetryEvent. The core of the issue surrounds how the PHP spread operator (...) works when it is uesd to expand an array into a function's named arguments.

If an array has both string and numeric keys it can cause issues. The numeric keys are passed the the function as positional arguments. While the string keys are passed to the function as named arguments. If both a numeric key and a string key refer to the same argument PHP will throw and exception.

Consider the following example...

$array = [
    0 => 'foo',
    'message' => 'bar',
];

function foo(string $message, string $other) {
    echo $message;
}

foo(...$array);

In this example both the 0 and 'message' keys resolve to the first argument, which causes PHP to throw an exception.

Because we have been using the spread operator when the body of TelemetryEvent is an array we are experiancing the same issue. I am fixing this issue in this PR by adding a new fromArray() method on TelemetryBody. The new method is then used instead of the constructor for array bodys.

Type of change

• Bug fix (non-breaking change that fixes an issue)

Related issues

• Fix New TelemetryEvent cannot handle nested array as $body argument #648
• SDK-455

Checklists

Development

• Lint rules pass locally
• The code changed/added as part of this pull request has been covered with tests
• All tests related to the changed code pass in development

Code review

• This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
• "Ready for review" label attached to the PR and reviewers assigned
• Issue from task tracker has a link to this pull request
• Changes have been reviewed by at least one other engineer