Fixed #613 Added response status code to verbose log message. #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmorell
added a commit
that referenced
this pull request
Apr 12, 2023
12 tasks
danielmorell
added a commit
that referenced
this pull request
Apr 14, 2023
…ail-status Backport of #614 Added response status code to verbose log message.
cyrusradfar
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This resolves issue #613 by adding the response status code from the API to the verbose log, if there is an error response status.
I also updated the associated test. Instead of posting to a non-existent endpoint, I sent an invalid access token. This seems more deterministic since we don't just want an error, we want a specific status code.
Type of change
Related issues
Checklists
Development
Code review- This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
- "Ready for review" label attached to the PR and reviewers assigned
- Issue from task tracker has a link to this pull request
- Changes have been reviewed by at least one other engineer