Remove VERSION constant in rollbar-android and load from metadata #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new metadata property has been added with the name "com.rollbar.notifier.version" in the library AndroidManifest that will be injected from gradle using manifest place holders.
waltjones
approved these changes
May 20, 2020
|
@waltjones my idea was to denote it, somehow, that the |
|
Got it. Makes sense. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new metadata property has been added with the name
com.rollbar.android._notifier.versionin the library AndroidManifestthat will be injected from gradle using manifest place holders.
This will help to handle the versioning as now the value used
is the
VERSION_NAMEcoming fromgradle.properties.