This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Lower deployment target to iOS 9.0 #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akornich yes, it compiles normally, but Xcode recommends to switch to iOS 12. Xcode 12 only dropped iOS 8 support, but iOS 9 and later are accessible. I'm currently using my fork in a project and all seems running ok. |
|
@GRiMe2D , got it. The build issue under Xcode 12 was actually triggered within KSCrash codebase that we depend on and it seemed persistent until I bumped the min iOS target to v12. I know KSCrash guys are already looking into it on their side to have an actual fix. But since you confirmed your changes behave with Xcode 12 let's go with it. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Removed all target overrides for iOS and macOS deployment target and set project wide. Lowered iOS deployment target from iOS 12.0 to iOS 9.0
Type of change
Related issues
Fix #338
Development
Code review