This repository was archived by the owner on Mar 7, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
Release candidate: v1.12.0 #263
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- feat: resolve Turn telemetry events into DTOs #261: Turn telemetry events into DTOs
- refactor: resolve Improve codebase layout by logically grouping source code files #262: Improve codebase layout by logically grouping source code files
- refactor: resolve Refactor RollbarTelemetry implementation #256: Refactor RollbarTelemetry implementation.
- refactor: resolve Mark deprecated public API with proper deprecated attribute #255: Mark deprecated public API with proper deprecated attribute.
- refactor: resolve Refactor RollbarNotifier's initializers #259: Refactor RollbarNotifier's initializers
- chore: resolve Remove dead code from RollbarNotifier #260: Remove dead code from RollbarNotifier
- test: resolve Fix failing testErrorReportingWithTelemetry unit test #257: Fix failing testErrorReportingWithTelemetry unit test
- test: resolve Fix deprecated API warnings in unit-test builds #258: Fix deprecated API warnings in unit-test builds
chore: ref rollbar#255: Mark deprecated public API with proper deprecated attribute.
…ecated attribute.
refactor: resolve rollbar#262: Improve codebase layout by logically grouping source code files
- fixed build warnings
- implemented Xcode code Analyzer's suggestions
akornich
commented
Mar 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.