Move Rollbar::ActiveJob out of the plugin #1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When will this be available in rubygems? |
|
@mudetroit can you release a new version in rubygems? |
|
@waltjones thanks 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR moves Rollbar::ActiveJob out of the plugin. This allows it to be available before plugin load, and when the action mailer integration is disabled.
The github diff shows a lot of +/- but it is just moving the module definition to be outside the plugin definition. (In the diff view, ⚙️ -> "hide whitespace" results in a much cleaner diff.)
Type of change
Related issues
Fixes: #1148