@pawelsz-rb Core functionality looks good. Two overall things to consider:

It makes sense to write to a file on disk if the zip is too big to keep in memory, but it looks like the zip is fully in memory anyway before writing it. I would consider either looking for a way to do the work fully in memory so you don't need to write temp files only to read them right back in. Or since that memory usage may be unacceptable for real world work loads, look for a way to chunk the work both during compress and during the stream upload. If it's not going to be chunked though, there's probably no upside to writing it to the file system.

Second thing is semicolons. Semicolon use is mixed throughout in this PR. Rollbar js projects in general use semicolons, so that's the style to follow. Maybe we should check the lint settings and see if this check can be enabled.

@pawelsz-rb Core functionality looks good. Two overall things to consider:

It makes sense to write to a file on disk if the zip is too big to keep in memory, but it looks like the zip is fully in memory anyway before writing it. I would consider either looking for a way to do the work fully in memory so you don't need to write temp files only to read them right back in. Or since that memory usage may be unacceptable for real world work loads, look for a way to chunk the work both during compress and during the stream upload. If it's not going to be chunked though, there's probably no upside to writing it to the file system.

Second thing is semicolons. Semicolon use is mixed throughout in this PR. Rollbar js projects in general use semicolons, so that's the style to follow. Maybe we should check the lint settings and see if this check can be enabled.

thank you for your constructive review, I think it was not that bad as for my very first js project. it's ready for another review

I think it was not that bad as for my very first js project.

Indeed! Not bad at all. Nice work. 👍