This repository was archived by the owner on Dec 19, 2024. It is now read-only.
Sending the actual error as a string and not the event #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianr
reviewed
May 16, 2017
| public function handleOtherEvent(event:*):String { | ||
| var newError:Error = new Error("A non-Error or ErrorEvent was thrown and not caught: " + event.toString()); | ||
| public function handleOtherEvent(error:*):String { | ||
| var newError:Error = new Error("A non-Error or ErrorEvent was thrown and not caught: " + error.toString()); |
There was a problem hiding this comment.
@pasviegas Would it be more useful to send both the event and the error? e.g. include both event.toString() and event.error.toString()
There was a problem hiding this comment.
Event will always be "[UncaughtErrorEvent type="uncaughtError" bubbles=true cancelable=true eventPhase=2]" so I don't see why sending it really. :)
|
@brianr Should we merge this or close it? |
|
Closing due to inactivity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.