Single file app fix #581
Merged
Single file app fix #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's strange. On my local machine all unit tests have passed. |
|
|
@Janek91 , you are good. It looks like there was an issue with Internet connectivity for the CI pipeline. I just reran the CI and it passed all tests. Thank you! |
akornich
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixed issue with single file applications in .NET 5. As ExecutingAssembly.Location will always return emty string - it is recommended to use AppContext.BaseDirectory to get current app executable directory path.
Type of change
Related issues
Checklists
Development
Code review