🎨 Move default theme markup to the app layout
#3167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐛 Fix uncontrollable HTML output (Fixes #3166)
QWp6t
approved these changes
Dec 20, 2023
retlehs
approved these changes
Dec 22, 2023
This was referenced Mar 18, 2024
|
I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing with Debug Bar, it appears that moving the default theme markup to the
applayout does not have any negative side-effects like before seen with Sage 9 (e.g. #2116). Another pair of eyes to confirm would be cool.Alongside being cleaner to maintain this stuff in Blade, this also fixes a lot of inconsistencies/rendering issues with Acorn's exception handler.
Change log
applayoutindex.phpfrom the Tailwind configget_headerhook abovewp_head()(Fixes do_action('get_header') should occur before wp_head() #3171)