🔧 Disable script concatenation by default #717
Conversation
|
Should we take it one step further to disable The CDN and web servers (e.g: nginx, apache, etc) should take care of those. |
|
I started getting problems with this after updating nginx from 1.21.7 to 1.27.2. Not with timeout to load-styles.php like many people report but nginx would just return connection reset by peer. Setting CONCATENATE_SCRIPTS to false solved the problem. Not sure why it happens but seems WordPress does something not compatible with latest nginx. |
Yes, I agree with @tangrufus - although those additions could become a separate issue/PR. Is there anything else preventing this PR being merged as it currently stands? It would be a great feature to have. |
I realise this is closed (thanks @retlehs), but wanted to expand to say that, on reflection, I think we should disable by default only the parts that a user’s likely server setup will handle by default; for example not everyone is using a CDN. Perhaps it could be a docs addition instead, or env vars added by trellis if the features are ones that it provides. It would be more helpful for me to submit a PR but I’m hoping these thoughts are still somewhat helpful. |
This PR sets
CONCATENATE_SCRIPTSto false by default which prevents WordPress from concatenating scriptsRef https://discourse.roots.io/t/upstream-timed-out-for-load-styles-php/26973