fix: use global alias for exceptions and linq select #1816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully I catched all references not yet qualified with |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors exception throwing and LINQ select statements by prefixing fully qualified names with the global alias.
- Update exception throwing calls (e.g., ArgumentNullException, ArgumentOutOfRangeException) to use the global:: prefix.
- Refactor LINQ Queryable.Select calls and other System references accordingly across production and test code.
Reviewed Changes
Copilot reviewed 136 out of 136 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/Riok.Mapperly.Tests/Mapping/GenericTest.cs | Updated exception throw expressions to use global::System.* references. |
| test/Riok.Mapperly.Tests/Mapping/GenericDerivedTypeTest.cs | Applied global:: prefix on exceptions in switch expressions. |
| test/Riok.Mapperly.Tests/Mapping/EnumerableTest.cs | Updated exception references in null-coalescing expressions. |
| test/Riok.Mapperly.Tests/Mapping/EnumerableDeepCloningTest.cs | Refactored exception handling to use the global alias. |
| test/Riok.Mapperly.Tests/Mapping/EnumToEnumExplicitMapTest.cs | Applied global:: prefix in exception throw expressions. |
| test/Riok.Mapperly.Tests/Mapping/EnumTest.cs | Consistently updated exception handling with global::System.* references. |
| test/Riok.Mapperly.Tests/Mapping/EnumRequiredMappingTest.cs | Refactored enum mapping exception throws to use global:: alias. |
| test/Riok.Mapperly.Tests/Mapping/DictionaryTest.cs | Updated exception in dictionary mapping to use a global alias. |
| test/Riok.Mapperly.IntegrationTests/_snapshots/* | Updated snapshots for LINQ select and exception throw expressions using the global alias. |
| src/Riok.Mapperly/Emit/Syntax/SyntaxFactoryHelper.Exception.cs | Updated exception constant values to include the global alias. |
| src/Riok.Mapperly/Descriptors/Mappings/QueryableProjectionMapping.cs | Refactored the LINQ receiver reference to use global:: when invoking Queryable methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now uses the
global::prefix for all FQN references. This change has been applied to exceptions and LINQ select statements.Fixes #1815