Add ResolveVisitor functionality #10

jasonwalsh · 2017-05-15T17:41:59Z

Verification steps:

nosetests -sv

Include additional keywords (e.g. `const`, `examples`) and update keywords class attribute.

Rename TypeRegistry to Creator and Object to Record.

Include `AllOf` and `Definitions` classes.

Include `Properties` class.

Ensure `$ref` value is valid against URI regular expression.

Ensure `Union` extends `Primitive` and update Union.fromJson method.

Rename primitives.Object to primitives.Record.

coveralls · 2017-05-15T17:43:07Z

Coverage decreased (-16.8%) to 64.497% when pulling f0468ea on feature/resolve-visitor into be5e575 on master.

coveralls · 2017-05-15T18:40:48Z

Coverage decreased (-16.8%) to 64.497% when pulling 2edc3c4 on feature/resolve-visitor into be5e575 on master.

Keywords `minimum` and `maximum` SHOULD NOT default to zero. Update unit tests to account for changes.

coveralls · 2017-05-15T19:17:57Z

Coverage decreased (-7.6%) to 73.684% when pulling c6f08a0 on feature/resolve-visitor into be5e575 on master.

coveralls · 2017-05-15T19:59:57Z

Coverage decreased (-7.7%) to 73.547% when pulling 31ff8fe on feature/resolve-visitor into be5e575 on master.

jasonwalsh · 2017-05-16T15:17:00Z

aptos/primitives.py

-    def fromJson(cls, instance, referrant=None):
-        return cls(**instance)
+        value = kwargs['$ref']
+        expression = r'^(([^:/?#]+):)?(//([^/?#]*))?([^?#]*)(\?([^#]*))?(#(.*))?'  # noqa: E501


re.compile

jasonwalsh · 2017-05-16T15:19:24Z

aptos/util.py

-        host=specification.get('host'), basePath=specification.get('basePath'),
-        paths=paths, definitions=definitions)
+    @staticmethod
+    def parse(filename):


def parse(instance)

rightlag added 25 commits May 15, 2017 09:54

Add Component class

e62934a

Update Primitive class

5c49dca

Include additional keywords (e.g. `const`, `examples`) and update keywords class attribute.

Rename TypeRegistry and Object

1081fe9

Rename TypeRegistry to Creator and Object to Record.

Remove resolve method from Primitive subclasses

3e62385

Remove Primitive.accept method

dfc1a89

Update Primitive.fromJson method

331e35c

Include `AllOf` and `Definitions` classes.

Update Array.fromJson and Array.__init__ methods

01e874f

Update Record.fromJson + Record.__init__ methods

b3e19df

Include `Properties` class.

Add Unknown class (name subject to change)

2e7cefa

Update RecordVisitor.visitDeclared method

e007011

Update RecordVisitor.visitUnion method

e1e515b

Add ResolveVisitor class

27157d0

Remove JSONSchema class

ec515ef

Update Reference.__init__ method

9362dd2

Ensure `$ref` value is valid against URI regular expression.

Add accept methods to Primitive types

926106e

Update Union class

671b16e

Ensure `Union` extends `Primitive` and update Union.fromJson method.

Move AllOf definition below Array definition

39bb6f3

Add ResolveVisitor.visitLong

c98d20c

Remove parse function and add Parser class

99416c8

Update RecordVisitor.visitDeclared

28757f5

Rename primitives.Object to primitives.Record.

Add product schema / update test_visitors module

5116611

Remove test_validators module

8ba13d0

Update test_loader module to use product schema

1ecb5b7

Add Enumerated class

63c2d10

Fix flake8 linting issues

f0468ea

Update README.md

2edc3c4

Update validation of numeric instances

c6f08a0

Keywords `minimum` and `maximum` SHOULD NOT default to zero. Update unit tests to account for changes.

Add visitEnum method to ResolveVisitor

31ff8fe

jasonwalsh commented May 16, 2017

View reviewed changes

jasonwalsh merged commit d5cdae6 into master May 18, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ResolveVisitor functionality #10

Add ResolveVisitor functionality #10

Add ResolveVisitor functionality #10

Add ResolveVisitor functionality #10

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment