Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce root layout container to be always present #5856

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enforce root layout container to be always present #5856

wants to merge 1 commit into from
+101 −108

Conversation

Wumpf
Copy link
Member
@Wumpf Wumpf commented Apr 8, 2024 •
edited
Loading

What

Previously, it was possible to end up without a root blueprint container which can cause weird ui behavior like not being able to add space views.
This is now solved by making up a root container upon reading the blueprint layout from the data store.

(Review with whitespace diff disabled!)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🪳 bug Something isn't working 🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md labels Apr 8, 2024
@Wumpf Wumpf marked this pull request as draft April 8, 2024 16:10
Base automatically changed from release-0.15.0 to main April 9, 2024 16:17
@Wumpf Wumpf force-pushed the andreas/enforce-root-layout branch from 18dc904 to 59790b5 Compare October 1, 2024 11:22
@Wumpf Wumpf added 🚜 refactor Change the code, not the functionality and removed 🪳 bug Something isn't working labels Oct 1, 2024
@Wumpf
Copy link
Member Author
Wumpf commented Oct 1, 2024

On a previous iteration with this some examples stopped working according to notes. Need to check if that's still the case

Wumpf
Wumpf commented Oct 1, 2024
View reviewed changes
crates/viewer/re_viewport_blueprint/src/viewport_blueprint.rs
.into_iter()
.filter_map(|id| ContainerBlueprint::try_from_db(blueprint_db, query, id))
.map(|c| (c.id, c))
.collect();

let root_container = root_container.map(|id| id.0.into());
let root_container = root_container.map_or_else(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the interesting part of the pr, everything else is just ripple effect

@Wumpf
Copy link
Member Author
Wumpf commented Oct 1, 2024

On a previous iteration with this some examples stopped working according to notes

still the case with web based examples at the very least

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Wumpf