Escape HTML from the params to avoid XSS #1790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varyonic
approved these changes
Feb 23, 2022
|
Great change, thank you! |
jwoodrow
pushed a commit
to moonproject/resque
that referenced
this pull request
Aug 5, 2022
* Escape HTML from the params to avoid XSS * Only escape the param when it's printed to the DOM
jwoodrow
added a commit
to moonproject/resque
that referenced
this pull request
Aug 8, 2022
This reverts commit 63bff1a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a penetration test, there were multiple Reflected XSS vulnerabilities found in the the web interface.
The following paths has been found vulnerable:
/failed/?class=<script>alert(document.cookie)</script>/queues/><img src=a >I have look through the other views, and found other places where HTML wasn't es 8000 caped from the params.