Add requeue_queue method to Resque::Failure::Multiple
#1659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzaleski
pushed a commit
to lantins/resque-retry
that referenced
this pull request
Nov 26, 2018
… backend This can be removed when the following PR is merged into `Resque` itself: resque/resque#1659
jeremy
reviewed
Nov 26, 2018
6d15c1d
9F5A
to
3249257
Compare
|
I just added a test that covers the related functionality. Please let me know if there is anything else you need. Thanks @jeremy ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
requeue_queuemethod toResque::Failure::Multiplethis is a hard requirement for the "retry-all" functionality to work via the Web UI and is currently causing issues w/in theresque-retrygem (which I maintain). This also seems to be an innocuous change toResqueitself.