Optimize deepEqual for TypedArrays #12809
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, we are not considering supporting TypedArrays atm, something we may do later on. |
|
Sure, no worries. Hope it'll make it in at some point. :) Just as a note, TypedArrays already work: if a field's value is set to a TypedArray it works just fine. The only issue is that when the array grows in size, the current implementation that compares the values takes a lot of time, hence the optimization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that when setting the value of a field to a large
Uint8Array(e.g., more than 1MB), the browser chokes while running thedeepEqualfunction, which performs poorly when dealing with that type of value. This PR fixes that problem. :)