Shade patch #8845
Shade patch #8845
Conversation
|
Please don't make new pull requests to update stuff, just force push the old one. That makes less noise for the maintainers - thanks. |
|
Noted. Sorry about that. Looks like I accidentally modified the local.md file while autogenerating the comments. Just removed those changes. Thanks for the help Nick! |
|
I gave this a quick look over @jhasse-shade and it looking good! I'll give it a detailed review later. First some questions
|
|
That's great to hear! Thanks Nick.
|
|
Also if you'd like any assistance with making an account/setting anything up please let me know, thanks. |
Got rid of Unlock statement in the middle of the refreshToken function, which was causing shared state to be updated outside of the lock. Now the lock is acquired at the beginning of the function, and let go at the end. Now only one gorouting will make an api call when needing to update the web token.
|
Just wanted to share, this fork is working great for me, would love to have it added to the master! |
…ashing logic to account for multipart upload/download
|
Hi @ncw, |
What is the purpose of this change?
This change is designed to implement a new backend for Shade, a cloud-based storage platform which allows users to store files securely and collaborate remotely, and mount them from anywhere. I've also included documentation on the backend and updated the docs.
I've compressed all our commits into one patch with the intention of making it easier to review. If it's necessary, I can provided full commit history documenting our implementation journey. It is all standard rclone behavior.
This new PR addresses the compile issues and small linting issues.
Was the change discussed in an issue or in the forum before?
No
Checklist
[ X] I have read the contribution guidelines.
[ X] I have added tests for all changes in this PR if appropriate.
[ X] I have added documentation for the changes if appropriate.
[ ?] All commit messages are in house style. (If the documentation provided is not enough, again I am more than happy to update the commit with in-depth details, but not trying to make it gigantic)
[ X] I'm done, this Pull Request is ready for review :-)