Allow to specify a type for references in migrations
#16231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
references in migrations
activerecord/CHANGELOG.md
Outdated
There was a problem hiding this comment.
can you add Example: above this line? See other entries for the general style.
|
Can you add the following to the commit message: This will credit both authors for the patch. |
There was a problem hiding this comment.
Any specific reason for this test?
There was a problem hiding this comment.
No, just followed other tests in this file…
|
@Envek added a couple minor comments. This patch looks good. Let me know when you updated the code. |
[Andrey Novikov & Łukasz Sarnacki]
|
Updated code, squashed, and rebased on top of current master. |
senny
added a commit
that referenced
this pull request
Jul 22, 2014
* Allow to specify a type for foreign key column in migrations * unified the docs * some cleanup in CHANGELOG
|
@Envek modified the docs and the CHANGELOG slightly. @lukesarnacki , @Envek thank you for your work 💛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to specify a type for created foreign key column in
referencesandadd_referencein migrations, very handy:Also I've changed PostgreSQL test to use this shiny functionality (looks better, eh?). And if anyone will ever remove this (not by reverting this PR), test will fail, showing that folks that use Postgres really need it ;-)
Bonus: documentation for
referencesmethod.P.S> After I wrote this PR I've found PR #13959 (which does the same, but little bit lengthy). Also see it for previous discussion. Choose either you like, I'll be happy with any of these PRs merged.
Will close #13959 if merged.