Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vhost-device-console backend & move it in main workspace #727

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update vhost-device-console backend & move it in main workspace #727

wants to merge 1 commit into from

Conversation

TimosAmpel
Copy link
Contributor

Summary of the PR

This PR updates the current implementation of vhost-device-console and addresses
the comments noted at the PR #717.

Specifically,

  • Eliminates the use of 'select' function and 'nix' dependency
  • Registers all input FDs to the main worker epoll handler
  • Increases the unit tests' coverage
  • Move the device into the main workspace

Requirements

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@TimosAmpel
Update vhost-device-console backend & move it in main workspace
ffb9934 
List of updates:
- Eliminate select function
- Add all input events on workers epoll
- Increase test coverage
- Move the device in main workspace

Signed-off-by: Timos Ampelikiotis <t.ampelikiotis@virtualopensystems.com>
@stefano-garzarella
Copy link
Member

Summary of the PR

This PR updates the current implementation of vhost-device-console and addresses the comments noted at the PR #717.

Specifically,

* Eliminates the use of 'select' function and 'nix' dependency

Cool, thanks for that!

* Registers all input FDs to the main worker epoll handler

* Increases the unit tests' coverage

* Move the device into the main workspace

All these steps in one commit?

This list should immediately make it clear that we need at least 3/4 separate commits. Please let's try to have commits as small as possible, also to make it easier for reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsquad stsquad Awaiting requested review from stsquad stsquad is a code owner

@vireshk vireshk Awaiting requested review from vireshk vireshk is a code owner

@stefano-garzarella stefano-garzarella Awaiting requested review from stefano-garzarella stefano-garzarella is a code owner

@epilys epilys Awaiting requested review from epilys epilys is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimosAmpel @stefano-garzarella