Update to winit 0.20.0 #1260
Merged
Update to winit 0.20.0 #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goddessfreya
suggested changes
Jan 7, 2020
|
I've tried to go through the clunky github CI and hopefully got it all now. Should all be working now hopefully. |
|
Sweet. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've taken the liberty to bump winit to version 0.20.0, since the recent DPI changes all have been merged.
I think the only potentially controversial thing is that I've blindly made all
PhysicalSizeinstances toPhysicalSize<u32>, since most usecases I saw in the code usedlet _: (u32, u32) = size.into();to immediately destructure the physical size into its width/height. However it's possible that there is an instance where u32 is not the optimal choice, I can't fully judge that myself.