-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce --rust-edition
#3002
Merged
Merged
Introduce --rust-edition
#3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvdrz
force-pushed
the
pvdrz/rust-editions
branch
3 times, most recently
from
November 29, 2024 22:21
b1e35b1
to
6717966
Compare
emilio
approved these changes
Nov 30, 2024
emilio
reviewed
Nov 30, 2024
Blocked by #3006 |
pvdrz
force-pushed
the
pvdrz/rust-editions
branch
2 times, most recently
from
November 30, 2024 03:28
94472e3
to
fd6ba69
Compare
Co-authored-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>
Co-authored-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>
27 tasks
pvdrz
force-pushed
the
pvdrz/rust-editions
branch
from
November 30, 2024 15:18
fd6ba69
to
3a5471b
Compare
thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of Rust editions to bindgen so it can generate appropriate code based on the desired edition.
The motivation behind this PR comes from #2996 which allows bindgen to generate code with C-String literals, a feature that has been available since rust 1.77 but are gated behind the 2021 edition.
The changes in this PR are:
--rust-edition
CLI argument andBuilder::rust_edition
method.literal_cstr
feature behind the 2021 edition.cc @nyurik @emilio