bump sccache for linux x86_64 to allow caching while PGO'd #133076
Conversation
|
r? infra-ci |
7e67423
to
876d02e
Compare
|
No promises about correct work with PGO :-) |
|
r? @Kobzol @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
bump sccache for linux x86_64 to allow caching while PGO'd This bumps sccache for linux-only jobs to allow sccache work with PGO mozilla/sccache#952 This is improvement: 2h05m -> 1h44m (from 1 run) for `dist-x86_64-linux` rust-lang#133033 (comment) Why still use old release? Commit with improvement was old, so i used some release around. In future, more recent versions can be tested to see if there any improvements, while this one already gives one. aarch64 update shouldn't change much, as there no PGO used. For other OSes i will create separate PRs later. r? infra
|
There is mozilla/sccache#1178 saying the first build will be fine, but later ones are failing. Definitely something to keep in mind if somebody notices spurious failures after merge. I'm a bit curious how the versions were selected. Previously it was upgraded to the latest available version. |
|
Now I think that I can be wrong with time improvement, because compared try build with auto. Yes, unrolled build around 1h47m, sad. |
|
Well, in that case I will hold that PR and update to more recent version to check other features. |
|
Oh shoot, I had read half of the description when I was interrupted. After coming back to it, I didn't remember to finish reading. |
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (a0fe848): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 2.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 11.9%, secondary 2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 788.599s -> 786.623s (-0.25%) |
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
bump sccache for linux x86_64 to allow caching while PGO'd This bumps sccache for linux-only jobs to allow sccache work with PGO mozilla/sccache#952 This is improvement: 2h05m -> 1h44m (from 1 run) for `dist-x86_64-linux` rust-lang#133033 (comment) Why still use old release? Commit with improvement was old, so i used some release around. In future, more recent versions can be tested to see if there any improvements, while this one already gives one. aarch64 update shouldn't change much, as there no PGO used. For other OSes i will create separate PRs later. r? infra
Isn't direct mode for local only cache? |
|
Right, in our setup, each builder keeps its own cache (local mode). This obviously works only with self hosted agents. |
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (fc7d7eb): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 0.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 1.2%, secondary 2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 788.11s -> 790.261s (0.27%) |
This bumps sccache for linux-only jobs to allow sccache work with PGO mozilla/sccache#952
This is improvement: 2h05m -> 1h44m (from 1 run) fordist-x86_64-linux#133033 (comment)Why still use old release? Commit with improvement was old, so i used some release around. In future, more recent versions can be tested to see if there any improvements, while this one already gives one.
aarch64 update shouldn't change much, as there no PGO used.
For other OSes i will create separate PRs later.
r? infra