-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inherent constructors on str
#131118
base: master
Are you sure you want to change the base?
Add inherent constructors on str
#131118
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #131269) made this pull request unmergeable. Please resolve the merge conflicts. |
The job Click to see the possible cause of the failure (guessed by this bot)
|
☔ The latest upstream changes (presumably #131767) made this pull request unmergeable. Please resolve the merge conflicts. |
I think it'll make your life much easier to do it in different PRs. Add the new ones first, then you can do separate PRs to update different parts of things to use the new ones, then once you're through that you can PR the future-deprecation. (Keeping it locally will help you make those other PRs, but no need to check it in for a while.) |
@robertbastian |
Sorry I'm afk until January 🙃 |
#131114
Unresolved questions
Do we mark the
core::str
functions as future-deprecation? This will causes warnings whencore::str
is imported andstr::from_utf8
is used, because the compiler decides to interpret that as the module, not the type.