Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make visit_clobber's impl safe #127560

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Make visit_clobber's impl safe #127560

merged 1 commit into from
Jul 11, 2024

Conversation

oli-obk
Copy link
Contributor
@oli-obk oli-obk commented Jul 10, 2024

This was originally introduced in #58061 but I didn't see any perf discussion about it, so let's see what perf says.

r? @nnethercote

@oli-obk
Copy link
Contributor Author
oli-obk commented Jul 10, 2024

@bors try @rust-timer queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 10, 2024
@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 10, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 10, 2024
@bors
Auto merge of rust-lang#127560 - oli-obk:safe_clobber, r=<try>
caf9e2f 
Make `visit_clobber`'s impl safe

This was originally introduced in rust-lang#58061 but I didn't see any perf discussion about it, so let's see what perf says.

r? `@nnethercote`
@bors
Copy link
Contributor
bors commented Jul 10, 2024

⌛ Trying commit 3562ec7 with merge caf9e2f...

@bors
Copy link
Contributor
bors commented Jul 10, 2024

☀️ Try build successful - checks-actions
Build commit: caf9e2f (caf9e2f04a628507c5aece14d75c64f69f806650)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (caf9e2f): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.2% [-0.2%, -0.2%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 3.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.3% [3.3%, 3.3%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.3% [3.3%, 3.3%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 703.707s -> 705.601s (0.27%)
Artifact size: 328.71 MiB -> 328.74 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 10, 2024
@oli-obk
Copy link
Contributor Author
oli-obk commented Jul 10, 2024

sweet

@nnethercote
Copy link
Contributor

Huh, interesting.

@bors r+

@bors
Copy link
Contributor
bors commented Jul 10, 2024

📌 Commit 3562ec7 has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2024
@bors
Copy link
Contributor
bors commented Jul 10, 2024

⌛ Testing commit 3562ec7 with merge 3ad5f45...

@bors
Copy link
Contributor
bors commented Jul 11, 2024

☀️ Test successful - checks-actions
Approved by: nnethercote
Pushing 3ad5f45 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 11, 2024
@bors bors merged commit 3ad5f45 into rust-lang:master Jul 11, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 11, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3ad5f45): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.7% [-1.1%, -0.2%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 704.958s -> 703.792s (-0.17%)
Artifact size: 328.69 MiB -> 328.53 MiB (-0.05%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nnethercote nnethercote

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oli-obk @rust-timer @bors @nnethercote @rustbot