Match ergonomics 2024: Implement TC's match ergonomics proposal #127008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
This comment has been minimized.
This comment has been minimized.
|
It works on my machine? |
|
@Jules-Bertholet: That's a debug assertion. You need to add: To your |
Under gate `ref_pat_eat_one_layer_2024_structural`. Enabling `ref_pat_eat_one_layer_2024` at the same time allows the union of what the individual gates allow.
f6af9e2
to
35f6b7b
Compare
Nadrieril
reviewed
Jun 30, 2024
|
Looks good! Just one procedural nit and then you can merge @bors delegate |
|
@bors delegate+ |
|
✌️ @Jules-Bertholet, you can now approve this pull request! If @Nadrieril told you to " |
|
Forgot I can push that kind of change myself |
|
@bors r+ |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 2, 2024
…rieril Match ergonomics 2024: Implement TC's match ergonomics proposal Under gate `ref_pat_eat_one_layer_2024_structural`. Enabling `ref_pat_eat_one_layer_2024` at the same time allows the union of what the individual gates allow. `@traviscross` r? `@Nadrieril` cc rust-lang#123076 `@rustbot` label A-edition-2024 A-patterns
|
💔 Test failed - checks-actions |
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
@bors retry |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 2, 2024
…rieril Match ergonomics 2024: Implement TC's match ergonomics proposal Under gate `ref_pat_eat_one_layer_2024_structural`. Enabling `ref_pat_eat_one_layer_2024` at the same time allows the union of what the individual gates allow. `@traviscross` r? `@Nadrieril` cc rust-lang#123076 `@rustbot` label A-edition-2024 A-patterns
|
💔 Test failed - checks-actions |
|
@bors retry |
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
@bors retry |
1 similar comment
|
@bors retry |
|
Oh it's in the queue. I got confused by out-of-order messages |
traviscross
approved these changes
Jul 3, 2024
tests/ui/match/ref_pat_eat_one_layer_2024/ref_pat_eat_one_layer_2024_fail.rs
Show resolved
Hide resolved
|
@bors rollup=iffy in case of weird perf results |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (2ad6630): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 2.4%, secondary 1.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 1.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 698.63s -> 698.523s (-0.02%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under gate
ref_pat_eat_one_layer_2024_structural. Enablingref_pat_eat_one_layer_2024at the same time allows the union of what the individual gates allow. @traviscrossr? @Nadrieril
cc #123076
@rustbot label A-edition-2024 A-patterns