Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): Reduce over-prescription to the caller #14217

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix(test): Reduce over-prescription to the caller #14217

merged 1 commit into from
Jul 9, 2024

Conversation

eth3lbert
Copy link
Contributor

This is a follow-up fix that addresses the suggestion made in #14200 (comment) for the remaining files.

@eth3lbert
fix(test): Reduce over-prescription to the caller
447ac75 
This is a follow-up fix that addresses the suggestion made in
rust-lang#14200 (comment)
for the remaining files.
@rustbot
Copy link
Collaborator
rustbot commented Jul 9, 2024

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 9, 2024
@weihanglo
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator
bors commented Jul 9, 2024

📌 Commit 447ac75 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2024
@bors
Copy link
Collaborator
bors commented Jul 9, 2024

⌛ Testing commit 447ac75 with merge b7823e3...

bors added a commit that referenced this pull request Jul 9, 2024
@bors
Auto merge of #14217 - eth3lbert:fix-snapbox-intodata, r=weihanglo
b7823e3 
fix(test): Reduce over-prescription to the caller

This is a follow-up fix that addresses the suggestion made in #14200 (comment) for the remaining files.
@bors
Copy link
Collaborator
bors commented Jul 9, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 9, 2024
@weihanglo
Copy link
Member

This is the second time we got the error:

 ---- doc::doc_all_workspace stdout ----
running `D:\a\cargo\cargo\target\debug\cargo.exe doc --workspace`
thread 'doc::doc_all_workspace' panicked at tests\testsuite\doc.rs:1217:10:

test failed running `D:\a\cargo\cargo\target\debug\cargo.exe doc --workspace`
error: process exited with code 101 (expected 0)
--- stdout

--- stderr
     Locking 2 packages to latest compatible versions
    Checking bar v0.1.0 (D:\a\cargo\cargo\target\tmp\cit\t1266\foo\bar)
 Documenting bar v0.1.0 (D:\a\cargo\cargo\target\tmp\cit\t1266\foo\bar)

thread 'main' has overflowed its stack
error: could not document `bar`

Caused by:
  process didn't exit successfully: `rustdoc --edition=2015 --crate-type lib --crate-name bar bar\src\lib.rs -o D:\a\cargo\cargo\target\tmp\cit\t1266\foo\target\doc --check-cfg cfg(docsrs) --check-cfg "cfg(feature, values())" --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat -C metadata=40cc2bd6c0ac6116 -L dependency=D:\a\cargo\cargo\target\tmp\cit\t1266\foo\target\debug\deps --crate-version 0.1.0` (exit code: 0xc00000fd, STATUS_STACK_OVERFLOW)

doc_all_workspace contains two packages foo and bar and it didn't every start documenting foo.

The previous one is here: #14209 (comment).

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2024
@bors
Copy link
Collaborator
bors commented Jul 9, 2024

⌛ Testing commit 447ac75 with merge a07056e...

bors added a commit that referenced this pull request Jul 9, 2024
@bors
Auto merge of #14217 - eth3lbert:fix-snapbox-intodata, r=weihanglo
a07056e 
fix(test): Reduce over-prescription to the caller

This is a follow-up fix that addresses the suggestion made in #14200 (comment) for the remaining files.
@bors
Copy link
Collaborator
bors commented Jul 9, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 9, 2024
@weihanglo
Copy link
Member

Looks like a network error.

---- https::github_works stdout ----
running `D:\a\cargo\cargo\target\debug\cargo.exe fetch`
thread 'https::github_works' panicked at tests\testsuite\https.rs:163:10:

---- expected: tests\testsuite\https.rs:158:27
++++ actual:   stderr
   1    1 | [UPDATING] git repository `[https://github.com/rust-lang/bitflags.git`](https://github.com/rust-lang/bitflags.git%60)
        2 + [WARNING] spurious network error (3 tries remaining): [7] Couldn't connect to server (Failed to connect to github.com port 443 after 2689 ms: Couldn't connect to server)
   2    3 | [LOCKING] 2 packages to latest compatible versions

Update with SNAPSHOTS=overwrite

note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2024
@bors
Copy link
Collaborator
bors commented Jul 9, 2024

⌛ Testing commit 447ac75 with merge 519c121...

@bors
Copy link
Collaborator
bors commented Jul 9, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 519c121 to master...

@bors bors merged commit 519c121 into rust-lang:master Jul 9, 2024
22 checks passed
@eth3lbert eth3lbert deleted the fix-snapbox-intodata branch July 9, 2024 22:58
@weihanglo weihanglo mentioned this pull request Jul 17, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 17, 2024
@bors
Auto merge of rust-lang#127838 - weihanglo:update-cargo, r=weihanglo
cb12b52 
Update cargo

31 commits in 154fdac39ae9629954e19e9986fd2cf2cdd8d964..a2b58c3dad4d554ba01ed6c45c41ff85390560f2
2024-07-07 01:28:23 +0000 to 2024-07-16 00:52:02 +0000
- chore(ci): bump CI tools (rust-lang/cargo#14257)
- test: migrate fetch and list_availables to snapbox (rust-lang/cargo#14214)
- chore: downgrade to jobserver@0.1.28 (rust-lang/cargo#14254)
- perf(source): Don't `du` on every git source load (rust-lang/cargo#14252)
- fix(source): Don't warn about unreferenced duplicate packages (rust-lang/cargo#14239)
- feat(test): Add cargo_test to test-support prelude (rust-lang/cargo#14243)
- Add workflow to publish Cargo automatically (rust-lang/cargo#14202)
- test: migrate implicit_features to snapbox (rust-lang/cargo#14245)
- test: migrate build-std/main to snapbox (rust-lang/cargo#14241)
- test: migrate check_cfg to snapbox (rust-lang/cargo#14235)
- refactor(source): More RecursivePathSource clean up (rust-lang/cargo#14231)
- Add more profiling traces (rust-lang/cargo#14238)
- fix(overrides): Don't warn on duplicate packages from using '..' (rust-lang/cargo#14234)
- fix(test): Redact elapsed time in the minutes time frame (rust-lang/cargo#14233)
- test: Migrate lto tests to snapbox (rust-lang/cargo#14209)
- fix: Ensure dep/feature activates the dependency on 2024 (rust-lang/cargo#14221)
- chore(docs): update index of reference (rust-lang/cargo#14228)
- test: migrate test to snapbox (rust-lang/cargo#14226)
- chore: remove duplicate words (rust-lang/cargo#14229)
- docs(contrib): Document things I look for in RFCs (rust-lang/cargo#14222)
- docs(ref): Note MSRV for features in the docs (rust-lang/cargo#14224)
- test(progress): Resolve flakiness (rust-lang/cargo#14223)
- fix(test): Reduce over-prescription to the caller (rust-lang/cargo#14217)
- refactor: move get_source_id out of registry (rust-lang/cargo#14218)
- fix: rename to `rustdoc::broken_intra_doc_links` (rust-lang/cargo#14215)
- test: migrate member_errors, multitarget and new to snapbox (rust-lang/cargo#14210)
- test: migrate generate_lockfile and glob_targets to snapbox (rust-lang/cargo#14200)
- test: Ensure --list test works with cargo-bloat (rust-lang/cargo#14213)
- dont make new constant InternedString in hot path (rust-lang/cargo#14211)
- Fix compatible_with_older_cargo test. (rust-lang/cargo#14212)
- test: migrate metabuild, metadata and net_config to snapbox (rust-lang/cargo#14162)
@rustbot rustbot added this to the 1.81.0 milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@weihanglo weihanglo

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
4 participants
@eth3lbert @rustbot @weihanglo @bors