tests: Import mtasc tests from gnash #21932

Dinnerbone · 2025-10-15T19:54:35Z

These are the easiest to port over as they don't require movie importing (which we don't have correct yet)

Source code for these is available at https://github.com/Dinnerbone/gnash-testsuit 8000 e/tree/master/testsuite/misc-mtasc.all

Aside from listed below, all other tests pass. I did however ignore the ExternalInterface test as that's not trivially testable in our framework (or FP for that matter).

Failures at time of PR:

Levels

--- flash player 32
+++ ruffle
@@ -2,7 +2,7 @@
 PASSED: -16384 == -16384  [levels.as:37]
 PASSED: _level0 == _level0  [levels.as:40]
 PASSED: 1 == 1  [level5.as:30]
-PASSED: _level0.frameno >= 1  [level5.as:32]
+FAILED: _level0.frameno >= 1  [level5.as:32]
 PASSED: -16379 == -16379  [level5.as:35]
 PASSED: _level5 == _level5  [level5.as:38]
 PASSED: _level0 == _level0  [level5.as:41]
@@ -15,10 +15,10 @@
 PASSED: 1 == 1  [level87.as:47]
 PASSED: -16297 == -16297  [level87.as:50]
 PASSED: _level87 == _level87  [level87.as:53]
-PASSED: _level0.frameno >= 2  [level87.as:65]
+FAILED: _level0.frameno >= 2  [level87.as:65]
 PASSED: 1 == 1  [level87.as:75]
 PASSED: 1 == 1  [level99.as:47]
-PASSED: _level0.frameno >= 2  [level99.as:49]
+FAILED: _level0.frameno >= 2  [level99.as:49]
 PASSED: -16285 == -16285  [level99.as:52]
 PASSED: _level99 == _level99  [level99.as:55]
 PASSED: _level99 == _level99  [level99.as:56]
@@ -34,35 +34,35 @@
 PASSED: goodbye == goodbye  [level99.as:81]
 PASSED: movieclip == movieclip  [level99.as:83]
 PASSED: -16379 == -16379  [level99.as:85]
-PASSED: undefined == undefined  [level99.as:87]
+FAILED: expected: "undefined" , obtained: "movieclip"  [level99.as:87]
 PASSED: movieclip == movieclip  [level99.as:88]
-PASSED: 10 == 10  [level99.as:89]
-PASSED: _level16394 == _level16394  [level99.as:90]
-PASSED: movieclip == movieclip  [level99.as:91]
-PASSED: 10 == 10  [level99.as:93]
-PASSED: _level16394 == _level16394  [level99.as:94]
+FAILED: expected: "10" , obtained: "-16379"  [level99.as:89]
+FAILED: expected: "_level16394" , obtained: "/"  [level99.as:90]
+FAILED: expected: "movieclip" , obtained: "undefined"  [level99.as:91]
+FAILED: expected: "10" , obtained: "-16379"  [level99.as:93]
+FAILED: expected: "_level16394" , obtained: "/"  [level99.as:94]
 PASSED:  ==   [level99.as:95]
 PASSED: _level5 == _level5  [level99.as:96]
-PASSED: 30 == 30  [level99.as:100]
-PASSED: _level16414 == _level16414  [level99.as:101]
-PASSED: 30 == 30  [level99.as:103]
-PASSED: _level16414 == _level16414  [level99.as:104]
+FAILED: expected: "30" , obtained: "-16285"  [level99.as:100]
+FAILED: expected: "_level16414" , obtained: "/"  [level99.as:101]
+FAILED: expected: "30" , obtained: "-16285"  [level99.as:103]
+FAILED: expected: "_level16414" , obtained: "/"  [level99.as:104]
 PASSED:  ==   [level99.as:105]
 PASSED: _level99 == _level99  [level99.as:106]
 Setting up onEnterFrame for _level99.ch [level99.as:108]
 PASSED: 1 == 1  [level87.as:47]
 PASSED: -16297 == -16297  [level87.as:50]
 PASSED: _level87 == _level87  [level87.as:53]
-PASSED: _level0.frameno >= 3  [level87.as:57]
-PASSED: undefined == undefined  [level87.as:59]
-PASSED: _level16394 == _level16394  [level99.as:117]
-PASSED: _level16414 == _level16414  [level99.as:118]
+FAILED: _level0.frameno >= 3  [level87.as:57]
+FAILED: expected: "undefined" , obtained: "movieclip"  [level87.as:59]
+FAILED: expected: "_level16394" , obtained: "/"  [level99.as:117]
+FAILED: expected: "_level16414" , obtained: "/"  [level99.as:118]
 PASSED: movieclip == movieclip  [level99.as:125]
-PASSED: undefined == undefined  [level99.as:126]
-PASSED: undefined == undefined  [level99.as:127]
+FAILED: expected: "undefined" , obtained: "string"  [level99.as:126]
+FAILED: expected: "undefined" , obtained: "function"  [level99.as:127]
 PASSED: undefined == undefined  [level99.as:128]
 PASSED: Test run 61 [ [level99.as:135]]
-#passed: 62
-#failed: 0
+#passed: 43
+#failed: 19
 #total tests run: 62
 __END_OF_TEST__

implementsOpTest

--- flash player 32
+++ ruffle
@@ -4,14 +4,14 @@
 PASSED: !ImplementationA.prototype instanceof SimpleInterface  [implementsOpTest.as:42]
 PASSED: !BExtendingImplementation instanceof ImplementationB  [implementsOpTest.as:43]
 PASSED: BExtendingImplementation.prototype instanceof ImplementationB  [implementsOpTest.as:44]
-PASSED: BExtendingImplementation.prototype instanceof SimpleInterface  [implementsOpTest.as:45]
+FAILED: BExtendingImplementation.prototype instanceof SimpleInterface  [implementsOpTest.as:45]
 PASSED: objectA instanceof ImplementationA  [implementsOpTest.as:51]
-PASSED: objectA instanceof SimpleInterface  [implementsOpTest.as:52]
+FAILED: objectA instanceof SimpleInterface  [implementsOpTest.as:52]
 PASSED: objectB instanceof ImplementationB  [implementsOpTest.as:54]
-PASSED: objectB instanceof SimpleInterface  [implementsOpTest.as:55]
+FAILED: objectB instanceof SimpleInterface  [implementsOpTest.as:55]
 PASSED: objectC instanceof BExtendingImplementation  [implementsOpTest.as:57]
 PASSED: objectC instanceof ImplementationB  [implementsOpTest.as:58]
-PASSED: objectC instanceof SimpleInterface  [implementsOpTest.as:59]
+FAILED: objectC instanceof SimpleInterface  [implementsOpTest.as:59]
 PASSED: 100 == 100  [implementsOpTest.as:64]
 PASSED: 100 == 100  [implementsOpTest.as:65]
 PASSED: param1 was foo == param1 was foo  [implementsOpTest.as:67]
@@ -22,7 +22,7 @@
 PASSED: ! objectA instanceof ImplementationA  [implementsOpTest.as:81]
 PASSED: ! objectA instanceof SimpleInterface  [implementsOpTest.as:82]
 PASSED: Test run 23 [ [implementsOpTest.as:91]]
-#passed: 24
-#failed: 0
+#passed: 20
+#failed: 4
 #total tests run: 24
 __END_OF_TEST__

TextFieldTest

This value seems to depend on OS, it's 19 on my windows and 18.05 on my linux

--- flash player 32
+++ ruffle
@@ -1,5 +1,5 @@
 PASSED: 100 == 100  [TextFieldTest.as:32]
-textfield height is 19 [TextFieldTest.as:38]
+textfield height is 17.2 [TextFieldTest.as:38]
 PASSED: height < 50  [TextFieldTest.as:39]
 PASSED: Test run 2 [ [TextFieldTest.as:40]]
 #passed: 3

kjarosh · 2025-10-17T20:03:19Z

Let's submit gnash patches here: https://github.com/ruffle-rs/gnash-testsuite (and change links to that repo)

Dinnerbone · 2025-10-17T20:27:04Z

Updated to point to repo and made ruffle-rs/gnash-testsuite#1

New folder structure also

@kjarosh

---------------------------------------------------------------------------------- clk.mk 564542420b840ffbaa57845220eda9636f7c330d # Version: Commits on Oct 19, 2025 ---------------------------------------------------------------------------------- Merge pull request #1609 from TomHarte/BBCAdvancedDiscToolkit BBC Micro: add ADT ROM if available., ------------------------------------------------------------------------------------------ duckstation.mk 9977e1dca00724f2f3406bda00ca613f7b89b355 # Version: Commits on Oct 19, 2025 ------------------------------------------------------------------------------------------ FullscreenUI: Disable rewind options when runahead is enabled (#3589), ----------------------------------------------------------------------------------- eden.mk df653d6ca469de48574193eab4398eb04f678916 # Version: Commits on Oct 19, 2025 ----------------------------------------------------------------------------------- [android, tools] remove unused XML strings; add script to find unused XML strings (#2777) ------------------------------------------------------------------------------------- hatari.mk b00976c86bed906594be53f892d6854f4aacf443 # Version: Commits on Oct 19, 2025 ------------------------------------------------------------------------------------- Split screen.c into two files screen.c now only contains SDL-related screen functions, and everything that takes care of converting the ST framebuffer to the host screen now goes into a new file called scrConvSt.c., -------------------------------------------------------------------------------------------- xenia-native.mk a1a33b9939e8bc95555bbecafeac97413b73ddea # Version: Commits on Sept 09, 2025 -------------------------------------------------------------------------------------------- [UI] Set ImGUI clipboard functions to GTK implementations, --------------------------------------------------------------- ruffle.mk nightly-2025-10-19 # Version: Commits on Oct 19, 2025 --------------------------------------------------------------- ## What's Changed * frontend_utils: Implement bundle exporter by @kjarosh in ruffle-rs/ruffle#21956 * tests: Import mtasc tests from gnash by @Dinnerbone in ruffle-rs/ruffle#21932 * frontend_utils: Put desktop-specific code behind features by @kjarosh in ruffle-rs/ruffle#21958 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-10-18...nightly-2025-10-19, ------------------------------------------------------------------------------------ box64.mk 609d5c27b2b2c344a57eec93d8b3078cd61e3b30 # Version: Commits on Oct 19, 2025 ------------------------------------------------------------------------------------ [WRAPPER] Added another listener to waylandclient (for #3071), --------------------------------------------------------------------------------------- corsixth.mk b8514ee6daa85f7b8159938839550861e304f411 # Version: Commits on Oct 18, 2025 --------------------------------------------------------------------------------------- Add the persistable comment header to the new local function. (#3077), ------------------------------------------------------------------------------------------- jazz2-native.mk 60a6b60a0b2c1d59e5c88f7b3d16e9327d3f06f8 # Version: Commits on Oct 18, 2025 ------------------------------------------------------------------------------------------- Big endian, ----------------------------------------------------------------------------------- raze.mk 6fa1f50483cf7b490e9a4b5e9fa513299fff699c # Version: Commits on Oct 19, 2025 ----------------------------------------------------------------------------------- - Use `maphoriz()` to document a horiz constant in Exhumed., ------------------------------------------------------------------------------------------------ libretro-mame-src.mk d9ff89ea6621fbeb53c2dc9c0ce088f4d94a8574 # Version: Commits on Oct 19, 2025 ------------------------------------------------------------------------------------------------ Merge remote-tracking branch 'upstream/master', ---------------------------------------------------------------------------------------- doomretro.mk be89f21a95b0bb0023e58edfaec01e6cf2cd4af5 # Version: Commits on Oct 19, 2025 ---------------------------------------------------------------------------------------- Fix calculating console timestamps, ------------------------------------------------------------------------------------- gzdoom.mk 725efeae702568a7e83004aa4ece57c5859353fb # Version: Commits on Aug 05, 2025 ------------------------------------------------------------------------------------- Fix wide char input. KeyChar should be unsigned for full 16-bit unicode, ------------------------------------------------------------------------------------------ xash3d-fwgs.mk f1fde32c292ee316559eaab7d504e033771cd4ce # Version: Commits on Oct 19, 2025 ------------------------------------------------------------------------------------------ Drop legacy AuroraOS code, ----------------------------------------------------------------------------------------------------- libretro-genesisplusgx.mk 97e931e9257f8ecd9da32704f8bcb6b06ca6ab30 # Version: Commits on Oct 19, 2025 ----------------------------------------------------------------------------------------------------- Migrate GameCube port to libogc2 (#538) * Migrate GameCube port to libogc2 * Stop motor for the right device on GameCube * Handle EOVERFLOW * Fix unmounting FAT devices on Wii,

Dinnerbone added A-tests Area: Tests & Test Framework T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Oct 15, 2025

Dinnerbone force-pushed the gnash/mtasc branch from 5fad95a to 6871d35 Compare October 15, 2025 22:00

kjarosh self-requested a review October 17, 2025 18:07

Dinnerbone force-pushed the gnash/mtasc branch from 6871d35 to e51ef9a Compare October 17, 2025 20:26

kjarosh approved these changes Oct 18, 2025

View reviewed changes

tests: Import mtasc tests from gnash

c644e8f

kjarosh force-pushed the gnash/mtasc branch from e51ef9a to c644e8f Compare October 18, 2025 09:06

kjarosh enabled auto-merge (rebase) October 18, 2025 09:07

kjarosh merged commit bed54f8 into ruffle-rs:master Oct 18, 2025
26 checks passed

Dinnerbone deleted the gnash/mtasc branch October 18, 2025 09:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

tests: Import mtasc tests from gnash #21932

tests: Import mtasc tests from gnash #21932

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

tests: Import mtasc tests from gnash #21932

tests: Import mtasc tests from gnash #21932

Uh oh!

Conversation

Failures at time of PR:

Levels

implementsOpTest

TextFieldTest

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants