-
-
Notifications
You must be signed in to change notification settings - Fork 924
web: Mark mouse_wheel_avm2
web integration test as flaky, allowing retries
#21967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
web: Mark mouse_wheel_avm2
web integration test as flaky, allowing retries
#21967
Conversation
…retries Yes, this is admitting defeat. For now.
:/ my every analysis shows it's impossible, but I'll be trying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
How ironic it is that this is failing in Edge. 🫠 All the retries did...? |
Are we supposed to do some additional cleanup with the trace capturing thingy when retry...? 🤔 |
What do you mean? |
That maybe some state is not properly cleaned across retries ... and/if for whatever reason they are more closely related than test cases to each other, in the way they are run. |
Or, maybe ... what if, in the cases when the test is failing, it's due to some glitched state of something larger or higher level that does not change across individual tests (connection to the browser, entire harness setup, no idea), therefore, if one try fails, all others will too, no matter how many? 😵💫 |
I'm not sure about it, failures are in different test cases |
So then is 3 just not enough? Vote on putting 5 there instead? Or 10? It's bikeshed time!! |
Yes, this is admitting defeat. For now.
I'm not proud, but I'm also not shameful. Just given in.
https://webdriver.io/docs/retry/#rerun-suites-in-mocha
https://mochajs.org/#retry-tests
https://mochajs.org/#arrow-functions