wgpu: Yeet the copy_srgb shader and pipeline #12720
Conversation
This was a workaround for the issue properly fixed by gfx-rs/wgpu#3817. That fix is in wgpu 0.17.0, and soon we can migrate to that. Even until then, with egui and rendering via MovieView, this is no longer causing problems with the desktop player, even using OpenGL.
|
This surely will just make it crash when the format is different, no? 😅 You still gotta tell it to change the srgbness |
As in, what format is different from what? 😶 The one we request vs. the one we end up getting?
And how would I do that? Sorry, I still don't speak wgpu... :| |
|
If the texture you're copying is srgb but you're copying it to rgb, or vice verca. When you make the texture view, you can specify that you want it in the same format but with/without srgb - that's how we should do it. |
|
Aaah, right!
This will have to wait though. Unless you want to do it in the meantime... |
This workaround won't be needed at all after either we move to wgpu 17.0.0, or gfx-rs/wgpu#3817 gets backported to wgpu 0.16.x.
And even until that, the desktop player is now fine even with OpenGL thanks to the indirect movie rendering through egui.
As for Android, I'm going to temporarily move to a patched wgpu 0.16 with the fix linked above.