tests: Unconditionally save 'actual.txt' with Ruffle output #11149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a test has large amounts of output, the diff printed by
Ruffle can be difficult to understand. Also, it can be useful
to see the real floating point values for a passing test with
approximate floating point comparison enabled.
I've modified the test runner to save the actual Ruffle trace output
to 'actual.txt' (in the same directory as 'output.txt'). For simplicity,
this is done regardless of whether or not the test passes or fails.
To prevent messy 'git status' output and accidental commits, I've added
all of the test-generated files ('actual.txt', 'different-*.png', and
'actual-*png') to .gitignore
|
This is a little bit awkward. IIRC other test frameworks create a temporary directory somewhere in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test has large amounts of output, the diff printed by Ruffle can be difficult to understand. Also, it can be useful to see the real floating point values for a passing test with approximate floating point comparison enabled.
I've modified the test runner to save the actual Ruffle trace output to 'actual.txt' (in the same directory as 'output.txt'). For simplicity, this is done regardless of whether or not the test passes or fails.
To prevent messy 'git status' output and accidental commits, I've added all of the test-generated files ('actual.txt', 'different-*.png', and 'actual-*png') to .gitignore