-
Notifications
You must be signed in to change notification settings - Fork 36
Add blog post for rubygems adoptions #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
af3ecd6
to
15a7207
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the ruby version, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really awesome @sonalkr132. Thanks for all you do for the community! ❤️
|
||
At the same time, we are also trying to allow users to request the reuse of an abandoned namespace by contacting the gem owner directly. We routinely receive [support tickets](https://help.rubygems.org/search?utf8=%E2%9C%93&q=abandoned&t=d&scope=all&category_id=&recommend=1) requesting access to an abandoned namespace that hasn't seen a release in quite a while. Finding the contact details of the owners can be a time-consuming process with limited scope for success. Recently we also decided that we will not show [user email publically by default](https://github.com/rubygems/rubygems.org/pull/2663), which users may have used in the past to contact owners. Using "Ownership requests", users will be able to submit such requests to gem owners using rubygems.org. | ||
|
||
## Ownership calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terminology behind this section seems confusing to me (as a non native 🇬🇧 speaker). TBH I had no idea what this section is about. I'm probably late to party here, but is there any reason to not use more common terminology like "Looking for maintainer"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that "ownership_call" is the name of th 8000 e model. We are trying to communicate that the user is asking (calling) for new ownerships. I agree that we are trying to invent a term here and this section attempts to explain what "ownership calls" mean.
any reason to not use more common terminology like "Looking for maintainer"
AFAIU, model names are almost always nouns. I am not sure pluralization would work for "looking_for_maintainer" in the context of the rails association. Further, we are looking for two model names, one created by owners and the other by users. Preferably they should use similar terms. Can you please suggest what could the name for objects created by users in response to "looking for maintainer"?
Are you suggesting we use "looking for maintainer" only for the blog?
TBH I had no idea what this section is about
Could you please elaborate with examples? I am hoping they are grammatically correct and coherent sentences. It is not very helpful to just say "I have no idea". What changes would you make?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, sorry for the delay. We can call that section "Looking for the maintainer" or something and keep the models the same. I think there is no need to keep the model and section names the same.
I think similar problem was raised at rubygems/rubygems.org#2892.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I had no idea what this section is about.
I was referring to the fact when I open the page, I have no idea what's the purpose thanks to used naming. That's my comment as non English native speaker. Maybe I have just some language gap, that's also possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I have updated the view to address some of your concerns here rubygems/rubygems.org#2910. I am sticking with ownership call/request naming for view with added explanation in subtitle and text area placeholder. I have added "looking for maintainer" as a tooltip. I would appreciate it if you could share your concerns or suggestions before it gets merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reminder to review the proposed PR so that we can avoid arguments after release.
Hi, I am moving ahead with this without confirmation from @simi on whether changes made to the adoption page addressed his concern. I have waited almost a month. |
Sorry :( I had no time to write down my notes. |
Please create a new issue with any further suggestions you may have. |
Related: rubygems/rubygems.org#2748
Rendered