No auto sign in after email confirmation #4810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinemde
commented
Jun 17, 2024
|
|
||
| assert page.has_content?("SIGN OUT") | ||
| assert page.has_content? "Sign in" | ||
| skip("There's a glitch where the webauthn javascript(?) triggers the next page to render twice, clearing flash.") |
There was a problem hiding this comment.
I didn't want to get into a big refactor in this PR because this is an existing problem. After successful webauthn, the javascript causes a double render of whatever page is next, clearing the flash that was set.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4810 +/- ##
==========================================
- Coverage 97.06% 97.06% -0.01%
==========================================
Files 399 399
Lines 8444 8443 -1
==========================================
- Hits 8196 8195 -1
Misses 248 248 ☔ View full report in Codecov by Sentry. |
indirect
approved these changes
Jun 17, 2024
fe73ef9 to
02407a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basing this decision on OWASP guidelines (for password resets, but the same principal applies):
The main goal being simpler login flows that are less likely to have mistakes or allow bypasses.