Add records for user & rubygem event logging #4406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4406 +/- ##
===========================================
+ Coverage 67.28% 97.02% +29.73%
===========================================
Files 339 349 +10
Lines 7675 7688 +13
===========================================
+ Hits 5164 7459 +2295
+ Misses 2511 229 -2282 ☔ View full report in Codecov by Sentry. |
1b69806 to
8dd3025
Compare
8dd3025 to
c6f1c7c
Compare
c6f1c7c to
f40f36e
Compare
simi
reviewed
Jan 30, 2024
simi
reviewed
Jan 30, 2024
simi
reviewed
Jan 30, 2024
simi
reviewed
Jan 30, 2024
simi
reviewed
Jan 30, 2024
|
|
||
| Gemcutter::PROXY_TOKEN = ENV["RUBYGEMS_PROXY_TOKEN"].presence | ||
|
|
||
| ActiveSupport.on_load(:action_dispatch_request) do |
There was a problem hiding this comment.
This is used to lazily populate the geoip_info and user agent info in the additional json on events once they eventually get recorded
martinemde
approved these changes
Jan 30, 2024
|
I extracted GeoipInfo to a separate table and also added test coverage for the code that was in the initializer (and moved it into a module so we can get code coverage on it) |
Merged
indirect
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #4367 to keep the diff smaller