Move browser tests to standard Rails system tests. #3374
Conversation
d289215 to
478dcad
Compare
Codecov Report
@@ Coverage Diff @@
## master #3374 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 113 113
Lines 3395 3395
=======================================
Hits 3347 3347
Misses 48 48 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Generally makes sense to me! I'm not too familiar with testing configurations so just to double check that the end product would look like:
- Browser tests under
/system. These tests areApplicationSystemTestCasethat wereSystemTests withheadless_chrome_driver. - System tests under
/system. These tests will inherit from something likeApplicationSystemTestCasebut with therack-testdriver instead of the selenium one. Right now, these are currentlySystemTestthat inheritsActionDispatch::IntegrationTestusing the rack-test driver. - Functional tests under
/functional(some integration tests can be moved here since they often only send one request per test).
If ^ is correct, would it make sense to somehow separate out the browser vs the other system tests into different directories (1 and 2.). At the end, would you suspect there to be any integration tests at all?
|
@jenshenny small naming issue fixed. Would it be ok to move with this forward? I'll continue on polishing tests. Regarding |
Other step into getting tests a little better structured aiming to visual regression testing.
This introduces classic Rails default
ApplicationSystemTestCasebacked byheadless_chrome(same as before) and utilisestest/systemdirectory for related tests. That should be equivalent of new Rails app these days.test/integrationstill hosts 2 kind of tests.ActionDispatch::IntegrationTestbased tests (usingget/postrails helpers to navigate combined with Capybara page assertions)SystemTestbased tests using Capybara style (visit, ...), but running usingrack-test(not running in browser)I would like to unify those two somehow. Some of the
ActionDispatch::IntegrationTesttests could be probably migrated tofunctionalfolder (for example API controller ones). Some of theActionDispatch::IntegrationTestcould be migrated toSystemTestusing browser like navigation instead ofget/postrails helpers.And finally
SystemTestcould be probably moved intosystemfolder using customTestCase(rack-testbased one).That would be subject of following PRs. Any suggestion is welcomed. 🙏