Fix Mocha deprecation warnings in tests. #3295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches to strict kwarg expectations in mocha. Conforms to kwarg vs hash arguments where needed. This also ran into the situation where delayed_job passes kwargs as a hash. I made a comment to explain why we couldn't switch to kwargs in Fastly.purge.
Codecov Report
@@ Coverage Diff @@
## master #3295 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 113 113
Lines 3390 3390
=======================================
Hits 3340 3340
Misses 50 50
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Ahh, thanks a lot. I have found out recently there are some warnings and I was about to find out what's happening. |
simi
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to strict kwarg expectations in mocha.
Conforms to kwarg vs hash arguments where needed.
This also ran into the situation where delayed_job passes kwargs as a hash. I made a comment to explain why we couldn't switch to kwargs in Fastly.purge since it was confusing for me at first and sent me down a small rabbit hole regarding delayed_job ruby 3.0 failures.