Add per user rate limit to gem push #3121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem push mfa rate limit is sensitive to brute force. we also want to add rate limit per user. Related: GHSA-8m6q-8hm4-fvh2 Also updates key used for rate limit to use display handle instead of plain text api key.
7fea34b to
22cbed8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
2CE3
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gem push mfa rate limit is sensitive to brute force. we also want to add rate limit per user. Limits are same as per IP limit.
Related:
GHSA-8m6q-8hm4-fvh2
Also updates key used for rate limit to use display handle instead of plain text api key.