Fix access to undefined variable version in GemcutterTaskshelper
#3068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rescue clause of the `get_spec_attribute` method is referencing `version.full_name` to build the log info message. The variable `version` is not defined in this context. I think the intended reference was to the parameter `version_full_name`. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com> Co-authored-by: Ryan Brushett <ryan.brushett@shopify.com>
simi
approved these changes
May 18, 2022
|
Well spotted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rescue clause of the
get_spec_attributemethod is referencingversion.full_nameto build the log info message but the variableversionis not defined in this context.I think the intended reference was to the parameter
version_full_name.