Redirect user to signin after webauthn error has occurred #3962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3962 +/- ##
==========================================
- Coverage 98.86% 98.86% -0.01%
==========================================
Files 221 221
Lines 5466 5465 -1
==========================================
- Hits 5404 5403 -1
Misses 62 62
|
28c0f4a to
94b6223
Compare
94b6223 to
fb8661c
Compare
jenshenny
commented
Jul 27, 2023
| @user = find_user | ||
|
|
||
| if @user&.mfa_enabled? | ||
| setup_webauthn_authentication(form_url: webauthn_create_session_path, session_options: { "user" => @user.id }) |
simi
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you solving?
Part of: #3335
What approach did you choose and why?
Currently, if a user enters the wrong totp code during mfa verification, they'll be redirected back to the sign in page. This PR would do the same with webauthn.
This would solve #3335 as the sign in flow would be reset and the correct session variables will be set when the user is prompted again. A reason I decided to redirect back to sign in instead of re-rendering the prompt page is that another error that could occur is that their login session is expired. It wouldn't make sense to re-render the prompt page as auth would always fail (the login session is expired).
Next steps
Will need to revisit the same for email confirmations, multifactor auth level update and password reset.