Extract GEM_NAME_RESERVED_LIST into database and include in admin panel. #3897

simi · 2023-07-02T01:59:10Z

follow-up of Add admin action to reserve a gem namespace #3875 (comment)
potentially closes Add ability to silence Gem::Package#build ruby/rubygems#6769
I'll remove reserve action in following PR if welcomed

codecov · 2023-07-02T02:10:59Z

Codecov Report

Merging #3897 (0d7f0ca) into master (0b9ecd3) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 0d7f0ca differs from pull request most recent head 1fe5027. Consider uploading reports for the commit 1fe5027 to get more accurate results

@@            Coverage Diff             @@
##           master    #3897      +/-   ##
==========================================
+ Coverage   98.80%   98.86%   +0.06%     
==========================================
  Files         217      221       +4     
  Lines        5436     5466      +30     
==========================================
+ Hits         5371     5404      +33     
+ Misses         65       62       -3

Files Changed	Coverage Δ
lib/patterns.rb	`100.00% <ø> (ø)`
app/avo/resources/gem_name_reservation_resource.rb	`100.00% <100.00%> (ø)`
...ontrollers/avo/gem_name_reservations_controller.rb	`100.00% <100.00%> (ø)`
app/controllers/rubygems_controller.rb	`100.00% <100.00%> (ø)`
app/models/gem_name_reservation.rb	`100.00% <100.00%> (ø)`
app/models/rubygem.rb	`98.70% <100.00%> (ø)`
app/policies/gem_name_reservation_policy.rb	`100.00% <100.00%> (ø)`

... and 3 files with indirect coverage changes

app/models/gem_name_reservation.rb

app/policies/gem_name_reservation_policy.rb

db/migrate/20230702010946_create_gem_name_reservations.rb

hsbt · 2023-07-04T05:48:04Z

👍 This feature is super helpful for me.

segiddins

Nice!

app/models/gem_name_reservation.rb

segiddins · 2023-07-18T22:34:59Z

@simi feel free to deploy whenever you're ready!

…min only.

…el. (#3897) * Extract GEM_NAME_RESERVED_LIST into database and include in admin panel. * Add unique validation for gem reservation and scope avo changes to admin only. * Add downcase name validation to gem name reservation model.

simi requested review from indirect and segiddins July 2, 2023 02:00

simi force-pushed the gem-reserved-name branch 2 times, most recently from 361b1ea to a05017a Compare July 2, 2023 02:03

simi force-pushed the gem-reserved-name branch 4 times, most recently from dc09692 to df80f87 Compare July 2, 2023 02:53

segiddins reviewed Jul 2, 2023

View reviewed changes

app/models/gem_name_reservation.rb Show resolved Hide resolved

app/policies/gem_name_reservation_policy.rb Show resolved Hide resolved

db/migrate/20230702010946_create_gem_name_reservations.rb Outdated Show resolved Hide resolved

simi requested a review from segiddins July 2, 2023 14:06

simi force-pushed the gem-reserved-name branch from 55ee2a3 to 9fa71e8 Compare July 2, 2023 14:11

mensfeld approved these changes Jul 13, 2023

View reviewed changes

simi force-pushed the gem-reserved-name branch from 9fa71e8 to 4ad22e3 Compare July 13, 2023 08:50

segiddins approved these changes Jul 14, 2023

View reviewed changes

app/models/gem_name_reservation.rb Show resolved Hide resolved

simi force-pushed the gem-reserved-name branch from 4ad22e3 to 60d3da9 Compare July 18, 2023 21:22

simi force-pushed the gem-reserved-name branch from 60d3da9 to 38d5275 Compare July 25, 2023 22:18

simi added 2 commits July 26, 2023 02:53

Extract GEM_NAME_RESERVED_LIST into database and include in admin panel.

1c484ba

Add unique validation for gem reservation and scope avo changes to ad…

f2e4618

…min only.

simi force-pushed the gem-reserved-name branch from 38d5275 to 0d7f0ca Compare July 26, 2023 00:53

Add downcase name validation to gem name reservation model.

1fe5027

simi force-pushed the gem-reserved-name branch from 0d7f0ca to 1fe5027 Compare July 26, 2023 00:56

simi merged commit 34325b6 into master Jul 26, 2023

simi deleted the gem-reserved-name branch July 26, 2023 01:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Extract GEM_NAME_RESERVED_LIST into database and include in admin panel. #3897

Extract GEM_NAME_RESERVED_LIST into database and include in admin panel. #3897

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Extract GEM_NAME_RESERVED_LIST into database and include in admin panel. #3897

Extract GEM_NAME_RESERVED_LIST into database and include in admin panel. #3897

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants